Repository navigation
fix(deps): patch runtime vulnerabilities and restore local gates - #369
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
|
Codex adversarial review on 7fca594, since CodeRabbit skips the dev base. Verdict: approve, no material findings. It checked both lockfiles against their manifests (no leftover vulnerable undici, sanitize-html, zod or source-map-js copies, no unrelated resolved/integrity drift), confirmed the replacement lefthook guards exist and pass, and read the release-safety change as additive. 148 targeted tests passed in its sandbox. One export test couldn't write there; the full suite is covered by the tests check on this head. Trace: Codex session 01a17501-06c1-7ee1-a0db-07ed3ab06eda. |
biggest-littlest
left a comment
There was a problem hiding this comment.
Approving 7fca594: Codex adversarial review clean, all required checks green on this head.
ALARGECOMPANY
left a comment
There was a problem hiding this comment.
Approving 7fca594: Codex adversarial review clean, all required checks green on this head.
The desktop runtime lock and npm workspace lock still select versions covered by the dependency findings. Update both runtime trees together so staging uses the reviewed patched versions.
The root lock also updates the existing Undici 6.x/7.x copies to compatible patched versions. Root dependency ranges are unchanged. The selected trees no longer match the nineteen advisory ranges checked for this repair; this is scoped dependency remediation, not a claim that all dependencies are vulnerability-free.
The pre-commit hook also references two deleted static-dashboard tests. Replace those paths with the current app-foundation, dashboard-retirement and YAML guards. Add a regression that rejects references to missing or untracked guard tests. Pre-push gates and branch protection stay intact.
Validation:
The full npm test command now limits concurrency to two workers while retaining
the same tests and skips. This avoids overloading the process-lifecycle fixtures
and applies equally to the local hook and CI.
This PR contains six files. Browser startup, PDF distribution and document-folder changes are separate local work. Signed native releases and artifact publication remain separate.