Skip to content

fix(deps): patch runtime vulnerabilities and restore local gates - #369

Merged
scttbnsn merged 3 commits into
dev/v0.16from
fix/runtime-security-repair
Oct 25, 2026
Merged

scttbnsn merged 3 commits into
dev/v0.16from
fix/runtime-security-repair

Conversation

@scttbnsn

Copy link
Copy Markdown
Contributor

The desktop runtime lock and npm workspace lock still select versions covered by the dependency findings. Update both runtime trees together so staging uses the reviewed patched versions.

Package Selected version
sanitize-html 2.18.1
undici 8.12.3
source-map-js 1.2.2
zod 4.6.7

The root lock also updates the existing Undici 6.x/7.x copies to compatible patched versions. Root dependency ranges are unchanged. The selected trees no longer match the nineteen advisory ranges checked for this repair; this is scoped dependency remediation, not a claim that all dependencies are vulnerability-free.

The pre-commit hook also references two deleted static-dashboard tests. Replace those paths with the current app-foundation, dashboard-retirement and YAML guards. Add a regression that rejects references to missing or untracked guard tests. Pre-push gates and branch protection stay intact.

Validation:

  • Full Node suite on this exact candidate: 5,448 passed, 20 skipped.
  • 112 focused document/network/HTML-security/ACP and packaging checks passed against the selected dependency trees.
  • Clean desktop dependency install and root lock consistency checks passed.
  • Biome and Knip passed.

The full npm test command now limits concurrency to two workers while retaining
the same tests and skips. This avoids overloading the process-lifecycle fixtures
and applies equally to the local hook and CI.

This PR contains six files. Browser startup, PDF distribution and document-folder changes are separate local work. Signed native releases and artifact publication remain separate.

@vercel

vercel Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
careerrat-website Ready Ready Preview Oct 25, 2026 4:01pm UTC

@coderabbitai

coderabbitai Bot commented Oct 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@scttbnsn

Copy link
Copy Markdown
Contributor Author

Codex adversarial review on 7fca594, since CodeRabbit skips the dev base.

Verdict: approve, no material findings. It checked both lockfiles against their manifests (no leftover vulnerable undici, sanitize-html, zod or source-map-js copies, no unrelated resolved/integrity drift), confirmed the replacement lefthook guards exist and pass, and read the release-safety change as additive. 148 targeted tests passed in its sandbox. One export test couldn't write there; the full suite is covered by the tests check on this head.

Trace: Codex session 01a17501-06c1-7ee1-a0db-07ed3ab06eda.

@biggest-littlest biggest-littlest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving 7fca594: Codex adversarial review clean, all required checks green on this head.

@ALARGECOMPANY ALARGECOMPANY left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving 7fca594: Codex adversarial review clean, all required checks green on this head.

@scttbnsn
scttbnsn merged commit f91bad0 into dev/v0.16 Oct 25, 2026
18 checks passed
This was referenced Oct 25, 2026

This branch was successfully deployed

1 active deployment
Preview — 7fca594a Deployed Oct 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants