Repository navigation
[9.1] fix (RMS): stop the ReqProxy from dropping the operations of cached requests - #8832
Merged
fstagni merged 2 commits intoOct 19, 2026
Merged
Conversation
…equests Request.__init__ and Operation.__init__ deleted the "Operations"/"Files" key from the dict they were given. Since c467386 the ReqProxy saves the dict it passed to Request() rather than the original JSON, so every request forwarded through a ReqProxy was stored without any operations.
…n them When a Waiting request has no operation to execute (e.g. it has no operations at all), RequestTask crashed with "'NoneType' object has no attribute 'Type'" and the agent picked the request up again a few minutes later, forever. Set an error on the request and delay it by a day instead, so it stays available for recovery.
This was referenced Oct 19, 2026
sfayer
approved these changes
Oct 19, 2026
fstagni
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The context is that
Request.__init__andOperation.__init__deleted the"Operations"/"Files"key from thedictthey were given.This then combined poorly with c467386 due to
json.dumps(requestDict)being called afterRequest(requestDict)meaning every request cached by aReqProxylost it'sOperations.In LHCb this has so far left ~14k empty requests in the RMS.
This PR fixes it by making it so that
Request.__init__andOperation.__init__no longer mutate the argument given to them.BEGINRELEASENOTES
*RequestManagement
FIX: The ReqProxy no longer drops the operations of the requests it caches
CHANGE: Request and Operation constructors no longer modify the dictionary they are given
ENDRELEASENOTES
EOF