Repository navigation
newMaster_20261020: merge devel into master - #287
Merged
Merged
Conversation
This fixes that only the last `-o` option takes effect for the pilot.
Make genericOptions a list
fix: purge the site installEnv variables
Contributor
Author
|
Integration tests green on the fork: https://github.com/fstagni/Pilot/actions/runs/39435601665 (second attempt; the first one failed on a GitHub API rate-limit flake in the workflow, unrelated to this change). Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merges
develintomasterfor production. Content-wise this is two fixes + one CI sync (already onmastervia cherry-pick e29b526):-o/--optionpilot arguments all take effect (previously only the last one).installEnvbefore repopulation, restoring pre-[devel] Small refactor to increase adaptability #203 behaviour.master;masteris otherwise fully contained indevel(verified withgit cherry).Evidence
develwith 8 checks passing (Make genericOptions a list #285 on Aug 25, purge the site installEnv variables #286 on Sep 23).Pilot/tests/Test_Pilot.py:PilotParams()with--option diracInstallOnly -o /LocalSite/Example=valueyieldsgenericOptions == ["diracInstallOnly", "/LocalSite/Example=value"].genericOptionattribute remain.Merge Danger
Door: two-way — revertable by reverting the merge commit, but pilot behaviour changes are user-visible immediately on production pilots.
Blast Radius: all pilots. The
-ohandling change (substring → exact membership fordiracInstallOnly/cvmfsOnly, and all options now forwarded) affects every pilot invocation; requires the LHCbPilot backward-compatibility fix to be in production. TheinstallEnvpurge changes the environment later pilot commands run in (no longer inheriting the full site environment).