Repository navigation
Conversation
|
yuecideng
added this pull request to stack #751
October 10, 2026 15:01
9 tasks done
This was referenced Oct 11, 2026
yuecideng
removed this pull request from stack #751
October 11, 2026 16:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add immutable scene pose candidates and an opt-in Task Program entry point that prepares one candidate, executes the canonical Task Program path, and requires separate measured acceptance. Acceptance requires normal completion of the selected canonical bridge and its final acceptance mask, independently of early Gym success. Recording rejection remains attached to the buffers until reset discards them; retries and replaced episode metadata cannot make rejected data saveable. Preparation, execution, and measurement share an attempt guard that blocks automatic resets and premature persistence.
lab.sim.scene_expansionowns bounded fixed candidates, permissions, rigid-transform validation, and reproducible proposal identity. Task Program integrations reuse the existing demo executor and persistence boundary. The executor accepts an explicit trusted segment iterable so an environment subclass cannot silently redirect this entry point into a handwritten expert action list.Includes the design from #748, API documentation, a routed project-context topic, and architecture nodes with source evidence for the scene core and Task Program entry point. The concrete workspace and physical-state host are the next layer.
Refs #748. Dependencies: existing Task Program and motion-expansion infrastructure; no new package dependency. This layer does not depend on PR #729.
Stack
mainType of change
Validation
black .completed; staged whitespace/header/annotation/export checks passed.scene-expansionowner and linked existing Task Program/workspace/motion context.This layer's integration tests use CPU physics/runtime ports and exercise the production demo and delayed persistence boundaries. Native scene preparation and workspace qualification belong to layer 2.
Screenshots
No UI change.
Checklist
black .with Black 26.3.1.