Repository navigation
Integrate scene workspace checks and add a UR5 showcase - #750
Merged
Merged
Conversation
yuecideng
added this pull request to stack #751
October 10, 2026 15:01
7 tasks done
yuecideng
force-pushed
the
codex/scene-expansion-workspace
branch
from
October 10, 2026 15:05
2253cd5 to
f31efad
Compare
[Medium impact] The PR appears safe to merge; no actionable issues remain from this review. SummaryAdds robot-aware scene checks, preparation through Gym reset, saved-state restoration, and a UR5 red/green workspace showcase.
|
yuecideng
force-pushed
the
codex/scene-expansion-workspace
branch
from
October 11, 2026 15:56
f31efad to
36989f7
Compare
This was referenced Oct 11, 2026
yuecideng
force-pushed
the
codex/scene-expansion-workspace
branch
from
October 11, 2026 16:39
36989f7 to
83ed8fc
Compare
yuecideng
removed this pull request from stack #751
October 11, 2026 16:41
yuecideng
changed the base branch from
codex/scene-expansion-contracts
to
codex/scene-foundation
October 11, 2026 16:42
yuecideng
added this pull request to stack #762
October 11, 2026 16:42
yuecideng
force-pushed
the
codex/scene-expansion-workspace
branch
from
October 11, 2026 16:50
83ed8fc to
16dc84a
Compare
yuecideng
force-pushed
the
codex/scene-expansion-workspace
branch
from
October 11, 2026 17:13
16dc84a to
83ed8fc
Compare
yuecideng
force-pushed
the
codex/scene-expansion-workspace
branch
from
October 13, 2026 14:20
ed91138 to
c862137
Compare
yuecideng
force-pushed
the
codex/scene-expansion-workspace
branch
from
October 13, 2026 14:42
ed91138 to
c862137
Compare
yuecideng
force-pushed
the
codex/scene-expansion-workspace
branch
from
October 17, 2026 11:31
118075e to
4ca63f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prepare and restore B=1 Task Program scene variants through the Gym reset lifecycle, and expose robot-aware workspace checks as reusable
sim.sceneservices. The UR5 round-table showcase makes the preparation decision visible: reject a red start before planning, then generate measured pick-and-place demonstrations from green starts.RobotSceneWorkspaceandSceneWorkspaceCandidateinsim.scene.workspace. Core checks returnSceneCheckReport; the Task Program compatibility adapter returnsValidationResult.scripts/tutorials/scene/:robot_workspace.pyowns the CLI and orchestration; four private sibling helpers own the scene/candidates, Task Program trial, display/capture and presentation video. Demo code is no longer shipped or documented as a public SDK API.The task gate requires program completion, at least 5 cm of measured lift, and a released cube within 4 cm of the goal for ten consecutive control steps at linear speed <= 0.03 m/s and angular speed <= 0.2 rad/s. Accepted trials save trajectory evidence; LeRobot writing is disabled by default.
Dependencies: shared scene services from #761. Existing package dependencies cover this implementation. Refs #760 and #748. Scene proposal imports use the canonical
sim.scene.expansionnamespace from #805.Showcase and documentation
Showcase guide · Original MP4
The guide embeds the full looping GIF (960 x 540, 8 fps, about 5 MiB), retains the original 1280 x 720, 25 fps MP4 download, and explains fixed-grasp color semantics, commands, acceptance and saved artifacts. Links from the Robot Workspace feature page and Simulation and Control tutorial index are retained.
The included seed-7 recording checks 1,190 object origins on a 2.4 m diameter round table: 703 pass and 487 fail. The red example produces zero actions; all three green starts complete measured pick-and-place trials. The committed GIF, video and screenshots are unchanged by the demo relocation.
Type of change
Validation
scene --view none,task --view none, andtask --view offscreen, all with seed 7 and three candidates. Task smokes were launched outside the repository to check path resolution. Both task runs succeeded 3/3; red rejection, first-frame cube poses and restoration passed. Candidate identities match across modes and views.Demo-specific unit, presentation and native-mode tests were removed with the SDK demo modules. Automated tests retain production workspace, state and host coverage; no tests import the tutorial implementation. The tutorial is checked through syntax/help checks and direct CLI smokes.
Native qualification used a temporary coherent DexSim Python overlay over the installed binary because the local SDK installation mixed versions. The qualified physical scope remains fixed-topology B=1, single-arm UR5, Default backend/CPU physics.
Context review: revise the scene-services overview to point to the tutorial-owned implementation; other ownership and runtime guidance remains accurate.
Checklist
black .with Black 26.3.1.