Repository navigation
Remove legacy scene expansion import package - #805
Merged
Merged
Conversation
[Medium impact] The PR appears safe to merge with the explicitly accepted import-path break. SummaryRemoves the legacy
Acknowledged intentional changes:
Review checks were static; no simulator tests were run during this review. Reviews (1) · Last reviewed commit: "refactor(scene)!: remove legacy scene ex..." · Reviewed by Greptile |
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the
embodichain.lab.sim.scene_expansioncompatibility package so scene expansion has a single import location:embodichain.lab.sim.scene.expansion. Existing users of the removed package must update their imports.Migrate the contract/source tests to
tests/sim/scene/expansion, update the Task Program integration test import, and remove compatibility assertions while retaining the canonical proposal-identity regression. Revise the scene context, routing paths, architecture seed, and design references. The generated architecture snapshot remains pinned to its historical source revision.Dependencies: none. No linked issue.
Type of change
Validation
black .with Black 26.3.1: passed; no formatting changes.python docs/scripts/check_api_docs.py: passed, 2594/2594 exports documented.python .agents/skills/project-dev-context/scripts/context.py check: passed.python -m pytest -q -c /dev/null -p no:cacheprovider --noconftest tests/test_agent_context_map.py tests/test_agent_context_tools.py: 40 passed after rebasing onto current main.git diff --check origin/main: passed.python -m pytest -q tests/sim/scene tests/gym/envs/task_program/test_scene_expansion.py: could not collect tests because the local environment lacksdexsim.engine, SciPy, Shapely, and Trimesh. The available gpu-sim environment also lacks DexSim. No simulator qualification is claimed.Context review: revised scene services/expansion guidance and paths to remove the deleted compatibility contract. General simulation and environment lifecycle guidance remains accurate because their behavior is unchanged.
Checklist
black .command to format the code base.python docs/scripts/check_api_docs.py), if applicable.