Repository navigation
Conversation
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 5, 2026
CI Report - 1a168b3run 42180082176 - attempt 1 0 failed - 33 passed - 0 skipped - 169m17s elapsed Test selection: full (selection-rule change) - per-suite table Coverage
Changed
Slowest jobs
e2e buckets run
|
Signed-off-by: Baylem <zelathis@gmail.com>
Select github.com/klauspost/compress v1.20.2 in all six affected standalone module graphs, including transitive consumers, and refresh their checksums. Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Keep the historical compress go.mod checksum required when loading transitive workspace module metadata. The selected compress source remains v1.20.2. Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #761 using the same reviewed commits on an upstream branch. Prior review discussion remains on that PR. Current-head CI is pending.
This PR independently targets master.
Wake requests could block beyond the join budget, report success while another request was still failing, and stall UDP receives. HostPort sleep/wake could also create the replacement listener before the previous pod released its port or move it away from the advertised node.
Bound the shared wake PATCH and total join attempt, propagate its actual result to concurrent callers, and coalesce UDP wake work behind a bounded queue. Persist the HostPort endpoint node and UID, wait for actual pod drain in both directions, and pin the game and sentinel through scheduler affinity. Missing or unschedulable endpoint nodes report an explicit condition.
Closes #729. Closes #730.
Validation:
Resource requests remain in the separate #724 change. This PR shares reconciliation code with #760; integration must retain its operation fence and these HostPort handoff gates. Existing web/Compose image builds on this base also need the unrelated template-picker fix in #759.
HostPort reconciliation also rechecks the recorded Node UID through the uncached reader immediately before StatefulSet mutation. A missing, deleting or replacement Node forces replicas to zero even while backup/restore ownership would retain them; a temporarily NotReady node may retain its existing running listener.
The same uncached GameServer endpoint and Node UID fence now runs inside sentinel Deployment mutation. Missing, deleting or replaced nodes stop an existing sentinel without rolling its pod template and cannot start a new listener.
CI installs Trivy v0.74.0 directly from its official GitHub release with bounded retries and a pinned SHA-256 checksum. The existing vulnerability scans and failure gates remain enabled.
Planning and Deployment mutation preserve an existing running listener on its original temporarily NotReady node, without starting or relocating a listener. Confirmed missing, deleting or replaced Node identities still stop it. Planner-to-mutation regressions cover both paths.
November 6 follow-up: The HostPort sentinel error string now satisfies ST1005; its corrected operator lint job passed before the dependency update. All six affected standalone Go modules now select
github.com/klauspost/compressv1.20.2 to fix GO-2026-6865. Module and workspace checksums are included. The patch was independently reviewed; standalone Linux builds, affected feature builds and controller regression-source compilation passed. Runtime tests and security scans run in CI under repository policy.Current validation: CI is running on
1a168b36after the signed stack updates. Earlier green results apply to their recorded commits; this head still requires fresh CI verification.