Repository navigation
[LTI] fix: allow deleting tools whose objects no longer exist - #12379
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Administration > LTI > ILIAS as LTI Platform (Consumer), deleting a tool fails with "At least one tool could not be deleted because it has usages (might be in trash)." although the tool has no usages: the column "Repository Usages" shows 0 and the tab "Usage" lists nothing.
ilLTITool::countUsages()counts every row oflti_consumer_settingsthat points to the tool, also rows of LTI objects that no longer exist in the system. The tab "Usage" and the usage columns only count objects with a reference, so both checks disagree and the tool can never be deleted.Fix
countUsages()only counts LTI objects that have a reference, in the repository or in the trash, as the tab "Usage" does.Testing
On a test installation with tools whose objects had already been removed from the system: the tools could not be deleted before the change, and they are deleted after it.