Skip to content

[LTI] fix: allow deleting tools whose objects no longer exist #12379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Saaweel merged 1 commit into from
Nov 5, 2026
Merged

[LTI] fix: allow deleting tools whose objects no longer exist #12379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions components/ILIAS/LTI/classes/Object/class.ilLTITool.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,14 +567,16 @@ public static function delete(array $ids): void
}

/**
* Number of LTI objects using one of the given tools. A tool in use must not be deleted.
* Number of LTI objects, in the repository or in the trash, using one of the given tools.
* A tool in use must not be deleted. Settings of objects that no longer exist are not usages.
*/
public static function countUsages(array $ids): int
{
$db = self::db();
$result = $db->query(
'SELECT COUNT(*) cnt FROM ' . ilObjLTITool::TABLE_NAME
. ' WHERE ' . $db->in('provider_id', $ids, false, 'integer')
'SELECT COUNT(DISTINCT s.obj_id) cnt FROM ' . ilObjLTITool::TABLE_NAME . ' s'
. ' JOIN object_reference r ON r.obj_id = s.obj_id'
. ' WHERE ' . $db->in('s.provider_id', $ids, false, 'integer')
);

return (int) $db->fetchAssoc($result)['cnt'];
Expand Down
Loading