Repository navigation
[FIX] Language: Check logged problems in the tests with PHPUnit 13.4 - #12387
Merged
c-knof merged 1 commit intoNov 5, 2026
Conversation
Since PHPUnit 13.4, `error_log()` is only captured after `expectErrorLog()`, so the 13 tests checking reported problems with `expectOutputRegex()` failed. The new trait `CapturesErrorLog` redirects the error log to a file per test, checks its content and fails a test on unexpected log entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PHPUnit 13.4,
error_log()is only captured afterexpectErrorLog(), so the 13 tests checking reported problems withexpectOutputRegex()failed. The new traitCapturesErrorLogredirects the error log to a file per test, checks its content and fails a test on unexpected log entries.