Repository navigation
test(fonts): FontSubsetterTests on macOS: say which outline is missing, skip the CID-keyed case there for now - #698
Merged
Conversation
…has none for the CFF original On macOS, SkiaSharp's CoreText typeface gives no glyph path for the CID-keyed CFF test font read from memory, so the comparison dereferenced null. Filee never draws with that font: the subset is TrueType. The subset must still have an outline for every glyph and the same advance; the boxes are compared where the original has a path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
KnifeLemon
added
the
macos
CoreText has no outline for the TrueType subset of the CID-keyed CFF sample (the subset itself, as the previous commit showed). #702 tracks the fix; the other platforms keep checking every glyph. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
KnifeLemon
changed the title
… an issue Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
KnifeLemon
changed the title
KnifeLemon
added
the
built-in engines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
FontSubsetterTests.Cff_font_becomes_a_truetype_subset_with_the_same_shapes(from #683) fails on macOS with aNullReferenceExceptionfor the CID-keyed sample (FileeTest-CID.otf). #683's CI didn't run the macOS jobs; #693 and #695 did, and both fail on it.The test now asserts what matters separately:
If the macOS run shows the subset is the one without outlines, this PR fails with that message, and the problem is in the PDF output rather than the test.
Type of change
How was it tested?
dotnet format --verify-no-changesdotnet test(FontSubsetterTests: 11 passed on Windows)macos)Checklist
src/Filee.App/Assets/i18n/*.jsonfiles (none)THIRD-PARTY-NOTICES.md(none)🤖 Generated with Claude Code