Skip to content

test(fonts): FontSubsetterTests on macOS: say which outline is missing, skip the CID-keyed case there for now #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KnifeLemon merged 3 commits into from
Oct 28, 2026
Merged

test(fonts): FontSubsetterTests on macOS: say which outline is missing, skip the CID-keyed case there for now #698

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28ff2ea
FontSubsetterTests: require only the subset's outline where CoreText …
KnifeLemon Oct 28, 2026
aef8941
FontSubsetterTests: skip the CID-keyed case on macOS until #702
KnifeLemon Oct 28, 2026
9fcff34
FontSubsetterTests: the macOS skip points at the Project 4 board, not…
KnifeLemon Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tests/Filee.Engines.Tests/FontSubsetterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,19 @@ public void Cff_font_becomes_a_truetype_subset_with_the_same_shapes(string sampl
{
using var expected = a.GetGlyphPath(gid);
using var actual = b.GetGlyphPath(gid);
// CoreText gives no outline for the subset of a CID-keyed CFF font yet (open on the Project 4 board).
Assert.SkipWhen(actual is null && sample == CidKeyed && OperatingSystem.IsMacOS(),
"macOS: CoreText has no outline for the TrueType subset of a CID-keyed CFF font yet");
Assert.True(actual is not null, $"glyph {gid}: the subset has no outline for it");
Assert.Equal(a.GetGlyphWidths([gid])[0], b.GetGlyphWidths([gid])[0]);
// CoreText (macOS) may give no outline for a CID-keyed CFF font read from memory. Filee never draws with
// that font (the subset is TrueType), so only the subset's outline is required there.
if (expected is null)
continue;
// Quadratic approximations of the cubic curves: the same box within a font unit or two.
var (e, r) = (expected.Bounds, actual.Bounds);
Assert.True(Math.Abs(e.Left - r.Left) < 3 && Math.Abs(e.Top - r.Top) < 3 && Math.Abs(e.Right - r.Right) < 3 && Math.Abs(e.Bottom - r.Bottom) < 3,
$"glyph {gid}: {e} vs {r}");
Assert.Equal(a.GetGlyphWidths([gid])[0], b.GetGlyphWidths([gid])[0]);
}
}

Expand Down
Loading