Skip to content

Fix OpenROM-bins Cloning, Remove Stale Commit Pin & Fix Working Directory Traversal - #142

Merged
ClausValcaTD merged 1 commit into
mainfrom
fix-openrom-bins-cloning-14752942830787187812
Oct 9, 2026
Merged

ClausValcaTD merged 1 commit into
mainfrom
fix-openrom-bins-cloning-14752942830787187812

Conversation

@ClausValcaTD

Copy link
Copy Markdown
Contributor

This PR addresses two issues with fetching OpenROM-bins:

  1. Removes hardcoded obsolete commit hash 586f7cc54df0facf9df9d3066c70e6b434b93753 from .github/workflows/Release.yml and .github/workflows/Flatpak.yml, allowing the latest OpenROM-bins from main (including checksums.sha256 and NKit 3.1.0 binaries) to be cloned.
  2. Fixes working directory traversal during checksum verification by using subshells (cd bins && ...) in workflows and pushd bins / popd in build_windows.bat, ensuring downstream copy commands correctly resolve paths relative to the repository root.

PR created automatically by Jules for task 14752942830787187812 started by @ClausValcaTD

…ectory traversal

Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ClausValcaTD
ClausValcaTD merged commit 314a4b8 into main Oct 9, 2026
1 check passed
@ClausValcaTD
ClausValcaTD deleted the fix-openrom-bins-cloning-14752942830787187812 branch October 9, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant