Skip to content

Fix OpenROM-bins Cloning, Remove Stale Commit Pin & Fix Working Directory Traversal #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ClausValcaTD merged 1 commit into from
Oct 9, 2026
Merged

Fix OpenROM-bins Cloning, Remove Stale Commit Pin & Fix Working Directory Traversal #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/Flatpak.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,7 @@ jobs:
- name: Clone OpenROM binaries repo
run: |
git clone --depth 1 https://github.com/M5Devs/OpenROM-bins.git bins
git -C bins checkout 586f7cc54df0facf9df9d3066c70e6b434b93753
cd bins && sha256sum -c checksums.sha256 && cd ..
(cd bins && sha256sum -c checksums.sha256)

- name: Set up Flutter
uses: subosito/flutter-action@v2
Expand Down
12 changes: 4 additions & 8 deletions .github/workflows/Release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ jobs:
shell: bash
run: |
git clone https://github.com/M5Devs/OpenROM-bins.git bins
git -C bins checkout 586f7cc54df0facf9df9d3066c70e6b434b93753
cd bins && sha256sum -c checksums.sha256 && cd ..
(cd bins && sha256sum -c checksums.sha256)

- name: Copy Windows binaries
run: |
Expand Down Expand Up @@ -154,8 +153,7 @@ jobs:
- name: Fetch binaries from OpenROM-bins
run: |
git clone https://github.com/M5Devs/OpenROM-bins.git bins
git -C bins checkout 586f7cc54df0facf9df9d3066c70e6b434b93753
cd bins && sha256sum -c checksums.sha256 && cd ..
(cd bins && sha256sum -c checksums.sha256)
mkdir -p assets/linux/x86_64
cp -r bins/linux/x86_64/. assets/linux/x86_64/
chmod +x assets/linux/x86_64/*
Expand Down Expand Up @@ -279,8 +277,7 @@ jobs:
- name: Fetch binaries from OpenROM-bins
run: |
git clone https://github.com/M5Devs/OpenROM-bins.git bins
git -C bins checkout 586f7cc54df0facf9df9d3066c70e6b434b93753
cd bins && sha256sum -c checksums.sha256 && cd ..
(cd bins && sha256sum -c checksums.sha256)
mkdir -p assets/linux/arm64
cp -r bins/linux/arm64/. assets/linux/arm64/
chmod +x assets/linux/arm64/*
Expand Down Expand Up @@ -387,8 +384,7 @@ jobs:
- name: Fetch binaries from OpenROM-bins
run: |
git clone https://github.com/M5Devs/OpenROM-bins.git bins
git -C bins checkout 586f7cc54df0facf9df9d3066c70e6b434b93753
cd bins && (sha256sum -c checksums.sha256 || shasum -a 256 -c checksums.sha256) && cd ..
(cd bins && (sha256sum -c checksums.sha256 || shasum -a 256 -c checksums.sha256))
mkdir -p assets/macos/arm64 assets/macos/x86_64
cp -r bins/macos/arm64/. assets/macos/arm64/
cp -r bins/macos/x86_64/. assets/macos/x86_64/
Expand Down
4 changes: 2 additions & 2 deletions build_windows.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
@echo off
if exist bins (
echo === Verifying OpenROM-bins checksums ===
cd bins
pushd bins
powershell -Command "Get-Content checksums.sha256 | ForEach-Object { $line = $_; $parts = $line -split ' '; if ($parts.Length -eq 2) { $hash = $parts[0].Trim(); $file = $parts[1].Trim(); if (Test-Path $file) { $actual = (Get-FileHash -Algorithm SHA256 $file).Hash.ToLower(); if ($actual -ne $hash) { Write-Error 'Checksum mismatch'; throw 'Checksum error' } } } }"
popd
if errorlevel 1 goto fail
cd ..
)
echo === Building OpenROM Core (Dart CLI) ===
cd core
Expand Down
Loading