Repository navigation
[trial] Exercise the Plugin tests workflow from #84 (do not merge) - #88
Closed
MyPrototypeWhat wants to merge 5 commits into
Closed
MyPrototypeWhat wants to merge 5 commits into
MyPrototypeWhat wants to merge 5 commits into
Conversation
Add .github/workflows/plugin-tests.yml, which runs on pull_request for plugins/** changes, detects changed plugins/<author>/<plugin> dirs that define scripts.test, and runs npm test in each via a matrix (Node 22, read-only permissions). Document plugin test conventions in CONTRIBUTING.md and CONTRIBUTING.zh-CN.md.
… and tell agents about plugin tests Review follow-up on the per-plugin test workflow: - detect: check out the PR merge commit with fetch-depth 2 and diff it against its first parent, instead of cloning the full history (108 MiB and growing) to diff base...head. - CONTRIBUTING (en/zh): use the repository's tests/ convention in the example, allow servers the test starts on 127.0.0.1 (only external hosts are off-limits), and say to delete the plugin's node_modules before npm run check, which rejects any node_modules inside a package. - AGENTS.md: add the plugin-test step, since agents read AGENTS.md rather than CONTRIBUTING. Assisted-by: Claude Opus 5.5 (OpenCode)
MyPrototypeWhat
pushed a commit
that referenced
this pull request
Oct 27, 2026
…nment A trial run (#88) on ubuntu-latest failed disk-insight's scanner tests, which assume macOS and Windows filesystem behaviour; on macos-latest they pass. MiniMax Code runs only on macOS and Windows, so the test job now runs on macOS (detection stays on Linux). The runner provides Node.js 22 and Git only. CONTRIBUTING (en/zh) and AGENTS.md now say so, and that a test needing another tool, such as FFmpeg or a browser, must skip itself when the tool is missing. cutline's FFmpeg-based tests fail on both runners until they do. Assisted-by: Claude Opus 5.5 (OpenCode)
Collaborator
Author
|
Trial finished; results are recorded in #84. Closing and deleting the branch. |
MyPrototypeWhat
added a commit
that referenced
this pull request
Oct 27, 2026
* ci: add per-plugin test workflow for changed plugins Add .github/workflows/plugin-tests.yml, which runs on pull_request for plugins/** changes, detects changed plugins/<author>/<plugin> dirs that define scripts.test, and runs npm test in each via a matrix (Node 22, read-only permissions). Document plugin test conventions in CONTRIBUTING.md and CONTRIBUTING.zh-CN.md. * ci(plugin-tests): diff the merge commit, document local node_modules, and tell agents about plugin tests Review follow-up on the per-plugin test workflow: - detect: check out the PR merge commit with fetch-depth 2 and diff it against its first parent, instead of cloning the full history (108 MiB and growing) to diff base...head. - CONTRIBUTING (en/zh): use the repository's tests/ convention in the example, allow servers the test starts on 127.0.0.1 (only external hosts are off-limits), and say to delete the plugin's node_modules before npm run check, which rejects any node_modules inside a package. - AGENTS.md: add the plugin-test step, since agents read AGENTS.md rather than CONTRIBUTING. Assisted-by: Claude Opus 5.5 (OpenCode) * ci(plugin-tests): run plugin tests on macOS and state the test environment A trial run (#88) on ubuntu-latest failed disk-insight's scanner tests, which assume macOS and Windows filesystem behaviour; on macos-latest they pass. MiniMax Code runs only on macOS and Windows, so the test job now runs on macOS (detection stays on Linux). The runner provides Node.js 22 and Git only. CONTRIBUTING (en/zh) and AGENTS.md now say so, and that a test needing another tool, such as FFmpeg or a browser, must skip itself when the tool is missing. cutline's FFmpeg-based tests fail on both runners until they do. Assisted-by: Claude Opus 5.5 (OpenCode) --------- Co-authored-by: dazhi <dazhi@minimaxi.com>
MyPrototypeWhat
added a commit
that referenced
this pull request
Oct 27, 2026
This reverts commit 475a658. The workflow runs each plugin's npm test on a clean macOS runner with Node.js 22 and Git only. The trial (#88) showed plugin tests depend on what is installed: cutline needs FFmpeg, which the runner lacks, and a CI-provided toolset would need its own install, pinning, and maintenance. Plugin authors keep their tests passing on their own machines instead, as CONTRIBUTING already asks them to test the app and report the environment in the pull request. Removes .github/workflows/plugin-tests.yml and the "Plugin tests" sections in CONTRIBUTING (en/zh) and AGENTS.md step 5. Assisted-by: Claude Opus 5.5 (OpenCode) Co-authored-by: dazhi <dazhi@minimaxi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway draft PR to run the
Plugin testsworkflow from #84 end to end. It touches the READMEs of the four plugins that have atestscript (timezone-guard, workflow-console, disk-insight, cutline) and of cq-viewer, which has none.Expected:
detectselects exactly the four, each gets its owntest (...)job, cq-viewer is skipped. This PR will be closed and its branch deleted once the run is read.Need help on this PR? Tag
@codesmith-botwith what you need.