Repository navigation
Conversation
The doc and doc-open tasks in Makefile-patina.toml now pass the alloc feature of patina to cargo doc. The patina crate no longer enables alloc by default. Without the flag, the generated docs omit every module that needs alloc. Refs: OpenDevicePartnership/patina#1919 Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com>
5 tasks
makubacki
approved these changes
Oct 26, 2026
vineelko
enabled auto-merge (squash)
October 26, 2026 19:34
vineelko
added a commit
to OpenDevicePartnership/patina
that referenced
this pull request
Oct 26, 2026
## Description Enable the alloc feature when building documentation The patina, patina_debugger, patina_internal_core and patina_internal_cpu crates now list alloc in their docs.rs metadata. The doc and doc-open tasks in Makefile.toml now enable the alloc feature of patina. Fixes: #1919 Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com> - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Ran `cargo make all` and checked the generated documentation to ensure it includes the modules gated behind `alloc`. ## Integration Instructions The changes to Makefile.toml will be retrofitted to patina-devops afterward(OpenDevicePartnership/patina-devops#214). Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com>
Javagedes
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.sync: Enable the patina alloc feature in the doc tasks
The doc and doc-open tasks in Makefile-patina.toml now pass the
alloc feature of patina to cargo doc.
The patina crate no longer enables alloc by default. Without the flag,
the generated docs omit every module that needs alloc.
Refs: OpenDevicePartnership/patina#1919, OpenDevicePartnership/patina#1920
Signed-off-by: Vineel Kovvuri[MSFT] vineelko@microsoft.com