Repository navigation
Conversation
Contributor
✅ QEMU Validation PassedAll QEMU validation jobs completed successfully.
Workflow run: https://github.com/OpenDevicePartnership/patina/actions/runs/40388164955 Boot Time to EFI Shell
Dependencies
This comment was automatically generated by the Patina QEMU PR Validation Post workflow. |
github-actions
Bot
added
the
impact:non-functional
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Javagedes
approved these changes
Oct 26, 2026
The patina, patina_debugger, patina_internal_core and patina_internal_cpu crates now list alloc in their docs.rs metadata. The doc and doc-open tasks in Makefile.toml now enable the alloc feature of patina. Fixes: OpenDevicePartnership#1919 Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com>
vineelko
force-pushed
the
users/vineelko/docs_alloc_fix_1026
branch
from
October 26, 2026 19:25
71aa41a to
a368d0d
Compare
makubacki
approved these changes
Oct 26, 2026
vineelko
enabled auto-merge (squash)
October 26, 2026 19:34
vineelko
added a commit
to OpenDevicePartnership/patina-devops
that referenced
this pull request
Oct 26, 2026
.sync: Enable the patina alloc feature in the doc tasks The doc and doc-open tasks in Makefile-patina.toml now pass the alloc feature of patina to cargo doc. The patina crate no longer enables alloc by default. Without the flag, the generated docs omit every module that needs alloc. Refs: OpenDevicePartnership/patina#1919, OpenDevicePartnership/patina#1920 Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com> Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable the alloc feature when building documentation
The patina, patina_debugger, patina_internal_core and
patina_internal_cpu crates now list alloc in their docs.rs metadata.
The doc and doc-open tasks in Makefile.toml now enable the alloc
feature of patina.
Fixes: #1919
Signed-off-by: Vineel Kovvuri[MSFT] vineelko@microsoft.com
How This Was Tested
Ran
cargo make alland checked the generated documentation to ensure it includes the modules gated behindalloc.Integration Instructions
The changes to Makefile.toml will be retrofitted to patina-devops afterward(OpenDevicePartnership/patina-devops#214).