feat: register mod-qualified input actions - #618
Merged
Merged
Conversation
Show menu scripts' actions in controls and keep bindings by qualified name. Share activation and rebinding with original controls, avoid stealing occupied defaults and suppress held presses on reload. Test persistence, conflicts, cancel/reset, edges and an action that sends a game event to start a custom order. Closes #617
Track registration generations for waits, conflicts and cancel state. Roll back only actions created by a failed script load, and reject case-only names that collide in saved profile keys. Share binding conflict lookup and keep original label rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Menu scripts register named actions shown in the controls screen. Bindings persist by mod-qualified name, defaults do not steal occupied controls, and input uses shared activation/rebinding paths. Player/menu scripts receive press edges through on_action; reload suppresses held controls until release.
Extend the custom-order example with Shift + F12 sending a game event. Tests cover names, conflicts, persistence, cancel/reset, controller buttons, reload and end-to-end delivery. The quality pass adds registration-generation guards, scoped failed-load rollback and case-insensitive saved-name collision checks.
Checks: 1,912 tests passed, one skipped; ReleaseSafe build, formatting and check-files pass. Other registries remain in #558.
Closes #617