Skip to content

[BLOCKED: PENDING TRACES] test: accept the OWNd#88 holiday readings for 13xxx/23xxx #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gdluck wants to merge 1 commit into from
Closed

[BLOCKED: PENDING TRACES] test: accept the OWNd#88 holiday readings for 13xxx/23xxx #650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions tests/test_message_edges.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,15 +186,19 @@ def test_mode_auto_variant_315(self):
assert isinstance(msg, OWNHeatingEvent)
assert msg.mode == CLIMATE_MODE_AUTO

def test_mode_auto_weekly_23001(self):
def test_mode_holiday_23001(self):
# OWNd <= 2.0.0b10 reads 23xxx as auto; OpenWebNet-HA/OWNd#88 reads it
# as the conditioning-season holiday (Legrand WHO 4 p. 5 / p. 64).
# Accept both until the pin moves past #88.
msg = OWNEvent.parse("*4*23001*1##")
assert isinstance(msg, OWNHeatingEvent)
assert msg.mode == CLIMATE_MODE_AUTO
assert msg.mode in (CLIMATE_MODE_AUTO, CLIMATE_MODE_COOL)

def test_mode_auto_weekly_13001(self):
def test_mode_holiday_13001(self):
# Same transition as above for the heating-season holiday (13xxx).
msg = OWNEvent.parse("*4*13001*1##")
assert isinstance(msg, OWNHeatingEvent)
assert msg.mode == CLIMATE_MODE_AUTO
assert msg.mode in (CLIMATE_MODE_AUTO, CLIMATE_MODE_HEAT)

def test_unknown_mode(self):
msg = OWNEvent.parse("*4*999*1##")
Expand Down
Loading