Repository navigation
Conversation
The vendored OWNd edge tests asserted the pre-OpenWebNet-HA#88 'auto' reading for *4*13001*1## and *4*23001*1##, which makes OWNd's downstream MyHOME job fail on OpenWebNet-HA/OWNd#88. Accept both readings until the OWNd pin moves past OpenWebNet-HA#88. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
PR Merging Blocked: Pending Authentic On-Wire Bus TracesIn accordance with OpenWebNet-HA repository and protocol verification standards:
Therefore, this PR is strictly blocked from merging until an authentic customer bus trace of a central unit in holiday operation is contributed from a physical installation. |
|
@xtimmy86x can you maybe help us out here with a trace? |
|
@nicolacavallo84 could you help us capture a quick trace from your BTicino 3550 central unit? To unblock the holiday / vacation parser validation for WHO 4, we need an authentic on-wire capture of the physical central unit emitting holiday operation:
Exporting the trace JSON from the Bus Monitor card ( |
Trace Gate Satisfied & PR SupersededThe trace gate blocking this PR has been satisfied: authentic physical on-wire bus traces from a BTicino F453AV (FW 3.0.14) operating Central Unit Furthermore, the test assertion relaxation in Closing this PR as superseded. |
Warning
Blocked Pending Authentic Customer Traces: This PR is blocked from merging. In accordance with the project's strict protocol conformance rules ("They are facts: never edit a frame"), relaxing test assertions for
*4*13001*1##and*4*23001*1##to accommodate OWNd#88 / OWNd#97 requires an authentic, untouched customer on-wire bus capture of a physical thermoregulation central unit emitting these frames on a live plant.Requested by A · project thread
Before:
tests/test_message_edges.py(MyHOME's copy of the OWNd edge tests) asserts that*4*13001*1##and*4*23001*1##parse asauto. OpenWebNet-HA/OWNd#88 reads them as the heating / conditioning holiday (Legrand WHO 4 v2.0.0 p. 5 and p. 64; libqtdevicesthermal_device.cpp:258-262, 303-307), so OWNd's downstream "MyHOME test suite" job, which runs this branch's tests against the OWNd pull request, fails on those two assertions.After: the two tests accept both readings (
autowith the pinned OWNd 2.0.0b10,heat/coolwith OWNd#88 and later), with a comment saying why. Checked locally: 182 passed against OWNd master and 182 passed against the OWNd#88 branch; the previous file fails 2 against OWNd#88.How:
tests/test_message_edges.pyonly, no integration code. Once the OWNd pin moves past #88 the assertions can be tightened to the new reading.🤖 Generated with Claude Code
https://claude.ai/code/session_018oHp1P4vxxoFnaLUUZpbpZ