Repository navigation
feat(climate): support WHO 4 season frames and generic setpoint mode (#649) - #657
Merged
GreenGrassBlueOcean merged 1 commit intoOct 8, 2026
Conversation
1 task done
…649) - Decode WHO 4 *4*1*Z## and *4*0*Z## season frames without altering running zone HVAC mode - Write generic mode 3 in async_set_temperature to preserve active plant season - Retain explicit mode 1 (heat) and 2 (cool) in async_set_hvac_mode - Maintain dual backward compatibility with released OWNd 2.0.0b10 and dev OWNd - Ensure 100% test coverage across both pinned OWNd 2.0.0b10 and newer OWNd releases Co-authored-by: gdluck <9041273+gdluck@users.noreply.github.com>
GreenGrassBlueOcean
force-pushed
the
feat/climate-audit-consolidated-649
branch
from
October 8, 2026 07:37
5da5314 to
7d9b7c8
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidated WHO 4 Climate Season & Setpoint Mode Fixes
Supercedes and resolves CI failures and architectural bugs identified in #649 and #650.
Audit & Root Cause Analysis of #649
tests/test_climate_season_frame.pyfailed CI due to Ruff violationI001 [*] Import block is un-sorted or un-formatted(import OWNd.message as own_messageplaced after Home Assistant imports). This triggered failure intests/test_ha_standards.pyandscripts/verify_ha_standards.py.async_set_hvac_mode:PR fix(climate): keep AUTO zones on season frames, write generic setpoint mode #649 changed
async_set_hvac_modeto sendmode=SETPOINT_WRITE_MODE(generic digit 3) when selectingHVACMode.HEATorCOOL. As confirmed by physical bus captures, digit 3 leaves the active season unchanged. Explicitly changing mode in Home Assistant to HEAT or COOL must send mode 1 (CLIMATE_MODE_HEAT) or mode 2 (CLIMATE_MODE_COOL). Generic digit 3 must only be written inasync_set_temperature().tests/test_heating.pyandtests/test_message_edges.pyare made dual-compatible with both released OWNd 2.0.0b10 (where*4*1*Z##reports ashvac_mode) and upcoming OWNd (where it reports ashvac_season).Changes
custom_components/myhome/climate.py:MESSAGE_TYPE_SEASONframes: retain existing zone HVAC mode if running; adopt season if off/none; update central unit dispatcher.async_set_hvac_mode.async_set_temperatureto writeSETPOINT_WRITE_MODE(generic 3).seasonextra state attribute.tests/test_climate_season_frame.py: Clean, Ruff-compliant imports.tests/test_component_climate.py: Verified setpoint writes assert digit 3 and mode changes assert digit 1/2.tests/test_heating.py: Dual-compatible assertion for season and mode.tests/test_message_edges.py: Dual-compatible assertion for holiday heating/cooling.Co-authored-by: gdluck 9041273+gdluck@users.noreply.github.com