Skip to content

test: initialize requested modules in codegen fixtures - #12790

Merged
proggeramlug merged 4 commits into
mainfrom
enf-module-fixtures
Oct 18, 2026
Merged

proggeramlug merged 4 commits into
mainfrom
enf-module-fixtures

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Codegen test targets failed with E0063 after HIR Module gained requested_modules. Initialize the empty source-request list in 40 synthetic Module constructors across 27 fixtures.

Validated on this branch with cargo check --release -p perry-codegen --tests. pmcheck.sh enf-module-fixtures passed the release build, archive sidecars, and zod/tsc smoke checks.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1f0dc497-2a8c-4ee3-8e1e-ef84004588d3
📥 Commits

Reviewing files that changed from the base of the PR and between 785bc1d and 4ac819d.

📒 Files selected for processing: 27
  • changelog.d/12790-codegen-module-fixtures.md
  • crates/perry-codegen/tests/app_window_config_options.rs
  • crates/perry-codegen/tests/argless_builtin_extra_args.rs
  • crates/perry-codegen/tests/class_field_store_pointer_test.rs
  • crates/perry-codegen/tests/class_keys_gc_root.rs
  • crates/perry-codegen/tests/constructor_recursion.rs
  • crates/perry-codegen/tests/crypto_hash_chain_lowering.rs
  • crates/perry-codegen/tests/error_subclass_field_init.rs
  • crates/perry-codegen/tests/i64_spec_ternary_recursion.rs
  • crates/perry-codegen/tests/ios_platform_api_lowering.rs
  • crates/perry-codegen/tests/large_object_barriers.rs
  • crates/perry-codegen/tests/loop_safepoint_purity.rs
  • crates/perry-codegen/tests/macos_bundle_chdir_gate.rs
  • crates/perry-codegen/tests/native_proof_buffer_views.rs
  • crates/perry-codegen/tests/native_proof_regressions.rs
  • crates/perry-codegen/tests/node_test_mock_property_presence.rs
  • crates/perry-codegen/tests/perry_builtin_name_collision.rs
  • crates/perry-codegen/tests/private_guard_declaring_class.rs
  • crates/perry-codegen/tests/release_boxes_lowering.rs
  • crates/perry-codegen/tests/scalar_replaced_slot_roots.rs
  • crates/perry-codegen/tests/shadow_slot_hygiene.rs
  • crates/perry-codegen/tests/static_symbol_hygiene.rs
  • crates/perry-codegen/tests/temp_root_operand_temporaries.rs
  • crates/perry-codegen/tests/typed_collection_receiver_guard.rs
  • crates/perry-codegen/tests/typed_feedback.rs
  • crates/perry-codegen/tests/typed_shape_descriptor.rs
  • crates/perry-codegen/tests/typed_shape_descriptors.rs
+------------------------------------------------------------------------------------------------------------------------------------+
| Put abstractions in code, details in metadata. Program for the general case, and put the specifics outside the compiled code base. |
+------------------------------------------------------------------------------------------------------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug
proggeramlug marked this pull request as ready for review October 18, 2026 09:37
@proggeramlug
proggeramlug merged commit 7f888d8 into main Oct 18, 2026
69 of 72 checks passed
@proggeramlug
proggeramlug deleted the enf-module-fixtures branch October 18, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant