Skip to content

fix(ui): use shared semantic live status indicator - #1031

Merged
IbrahimIjai merged 3 commits into
SO4-Markets:mainfrom
Ay-obami:fix/924-shared-live-indicator
Oct 21, 2026
Merged

IbrahimIjai merged 3 commits into
SO4-Markets:mainfrom
Ay-obami:fix/924-shared-live-indicator

Conversation

@Ay-obami

@Ay-obami Ay-obami commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Changes

  • [Design system] Apply the density preference everywhere #923: Apply the existing root density preference to shared table-cell spacing and depth-ladder row sizing; document compact/default/comfortable behavior without breaking standalone React consumers.
  • [Design system] Status colour semantics for live indicators #924: Centralize LiveIndicator with semantic success/warning/destructive tokens, reduced-motion-safe pulse, accessibility tests, and design-system documentation.
  • [Performance] Main entry chunk is 1.4 MB #925: Remove the eager Stellar SDK import from the app-wide network configuration (retain exact canonical network passphrases); this cuts the measured main entry JS chunk from 1,546,883 to 511,868 bytes (~67% smaller).
  • [Performance] contracts chunk 725 KB #926: Keep the existing trade/pools/earn route lazy-loading; expose the contract error helper through a lightweight package subpath and use it from the shared TxStatus so shared UI no longer imports the eager contract-client barrel. Current client contracts chunk is ~31.6 KB, not the 725 KB reported in the older issue snapshot.

Verification and limitations

  • PASS: Production web build; UI and contracts package typecheck; network tests (2); LiveIndicator tests (6). Prior main test suite and coverage checks passed.
  • Existing unrelated repo failures persist: segmented-control lint, DepthLadder.test.tsx malformed selector (web typecheck), and NetworkHealthIndicator design-token violation.
  • Visual light/dark before-and-after screenshots and Lighthouse/DevTools measurements are not attached. Bundle sizes measured from Vite output; baseline and post-change measurements are not a Lighthouse score.
  • The repository default branch is main. The user explicitly authorized submitting despite unrelated baseline gate failures.

Closes #923
Closes #924
Closes #925
Closes #926

The repository-wide gate has existing unrelated failures in segmented-control lint, DepthLadder test syntax and NetworkHealthIndicator token validation. User authorized proceeding despite those baseline failures.
@vercel

vercel Bot commented Oct 20, 2026

Copy link
Copy Markdown

@Ay-obami is attempting to deploy a commit to the Ijai's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Oct 20, 2026

Copy link
Copy Markdown

@Ay-obami Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

…ies (SO4-Markets#923 SO4-Markets#925 SO4-Markets#926)

Baseline web typecheck fails on existing DepthLadder.test.tsx malformed selector; existing lint and token gate issues are unrelated to these changes. Proceeding with user authorization.
@Ay-obami
Ay-obami force-pushed the fix/924-shared-live-indicator branch from f5f76d7 to 0887f84 Compare October 20, 2026 22:43
@IbrahimIjai
IbrahimIjai merged commit 15a080b into SO4-Markets:main Oct 21, 2026
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants