Repository navigation
Fix BlockType type brand and a comment typo - #41
Open
Avicennasis wants to merge 1 commit into
Open
Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
EnumValue<'Blocktype'> did not match its EnumDecl<'BlockType'> / enum_('BlockType'); type-only change, no runtime effect. Also capitalize a sentence in util.content.ts.
Signed-off-by: Léon Avic Simmons <Avicennasis@gmail.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/plugins/enums.tsL12:export type BlockType = EnumValue<'Blocktype'>;→EnumValue<'BlockType'>. The declaration on the next line isEnumDecl<'BlockType'> = enum_('BlockType', …), so enum values carrykind: 'BlockType'and were not assignable to the exportedBlockTypetype. Every other enum in the file uses matching brands. This is a type-only change with no runtime effect, and nothing in the repo references the type alias.src/plugins/util.content.tsL22:See CMS-33805. for those,→See CMS-33805. For those,SliceType.NEWSLETTERL(enums.tsL153) looks like a typo forNEWSLETTER, but it is a key on an exported enum, so it was deliberately left for maintainers to decide.No runtime changes: one type annotation and one comment.