Skip to content

Fix BlockType type brand and a comment typo #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Avicennasis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix BlockType type brand and a comment typo #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/enums.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export const BackgroundSource: EnumDecl<'BackgroundSource'> = enum_('BackgroundS
NONE: [4, 'none'],
});

export type BlockType = EnumValue<'Blocktype'>;
export type BlockType = EnumValue<'BlockType'>;
export const BlockType: EnumDecl<'BlockType'> = enum_('BlockType', {
UNDEFINED: [-1, 'undefined'],
NAVIGATION: [1, 'navigation'],
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/util.content.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const getFocalPoint = (media: Node) => {

export const getAltText = (ctx: Context, image: Node): string => {
// Content items for image blocks were populated with an altText value with a migration.
// See CMS-33805. for those, the content item value should always be used even if it is empty.
// See CMS-33805. For those, the content item value should always be used even if it is empty.
const blockType = ctx.resolve(['blockType']);
if (!blockType.isMissing() && blockType.asNumber() === BlockType.IMAGE.code) {
const altText = image.path(['altText']);
Expand Down