Repository navigation
CDA-142 - Switch FAIL_IF_EXISTS to OVERRIDE_PROTECTION for gate change post endpoint - #1992
Merged
Merged
Conversation
Documentation build overview
No files changed. |
RyanM-RMA
force-pushed
the
bugfix/CDA-142
branch
from
October 5, 2026 19:15
3ca17e1 to
5a84524
Compare
RyanM-RMA
changed the title
zack-rma
suggested changes
Oct 5, 2026
| .body(json) | ||
| .header(AUTH_HEADER, USER.toHeaderValue()) | ||
| .queryParam(FAIL_IF_EXISTS, "false") | ||
| .queryParam(OVERRIDE_PROTECTION, "false") |
Collaborator
There was a problem hiding this comment.
Perhaps include a test to verify the old query parameter can still be used for the time being
Collaborator
Author
There was a problem hiding this comment.
Integration test implementation will come in a second PR. The problem right now is that it's still updating the record, in spite of a protected flag on the record and an override protection flag of false. Might require a DB change to resolve that issue.
MikeNeilson
approved these changes
Oct 8, 2026
…patability and note.
…added deprecated flag for FAIL_IF_EXISTS.
MikeNeilson
force-pushed
the
bugfix/CDA-142
branch
from
October 8, 2026 13:57
d2d8db2 to
60f5c63
Compare
rma-bryson
approved these changes
Oct 8, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switched FAIL_IF_EXISTS to OVERRIDE_PROTECTION for gate change post endpoint. Updated unit tests
Related Issue
Closes #1906
Jira Ticket: https://jira.hecdev.net/browse/CDA-142
Validation
Verified with unit tests
Checklist