Repository navigation
Conversation
RyanM-RMA
changed the title
Documentation build overview
No files changed. |
0a884f2 to
541aa0a
Compare
| .then() | ||
| .log().ifValidationFails(LogDetail.ALL, true) | ||
| .assertThat() | ||
| .statusCode(not(HttpServletResponse.SC_CREATED)); |
There was a problem hiding this comment.
Add check here that real mutation occurred.
There was a problem hiding this comment.
No mutation is expected. I could switch it over to is(SC_BAD_REQUEST) so it's more obvious. I wasn't sure what the exact code is supposed to be, just that it's not SC_CREATED since that's the OK response.
There was a problem hiding this comment.
Right, should be checking it DID NOT* occur. We should verify that the data wasn't actually mutated here, in case things fail silently.
There was a problem hiding this comment.
I think that would just be a retrieval before this status code assertion to ensure the original data is what we get back, not the updated data.... or a separate test that doesn't check the status code, and just does the subsequent retrieval to ensure its the original data.
Summary
Adding unit test for OVERRIDE_PROTECTION flag in gate changes. This PR is an example of an unexpected failure of the DB.
Related Issue
Related to #1906
Related to PR #1992
Validation
Validated through running the unit test
Checklist