Hoist loop-invariant work out of get_calendar() - #13615
mukeshpanchal27 wants to merge 1 commit into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The optimization preserves existing behavior while removing repeated time lookups.
Review effort: Lite
Findings: None
What changed in this PR
Hoists the current date lookup in get_calendar() and reuses parsed values for month selection and today highlighting.
Changes:
- Retrieves year, month, and day once.
- Replaces repeated
current_time()calls in the loop.
| File | Description |
|---|---|
src/wp-includes/general-template.php |
Optimizes current-date handling in get_calendar(). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Trac ticket: https://core.trac.wordpress.org/ticket/66141
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Drafting the ticket description. Reviewed and verified by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.