Skip to content

feat(multisig): build multi-sig action indexer and pending approvals REST API (#1085) - #1183

Merged
Chucks1093 merged 3 commits into
accesslayerorg:mainfrom
VictorEzenma:feat/multisig-action-indexer-1085
Oct 24, 2026
Merged

Chucks1093 merged 3 commits into
accesslayerorg:mainfrom
VictorEzenma:feat/multisig-action-indexer-1085

Conversation

@VictorEzenma

Copy link
Copy Markdown
Contributor

I have successfully implemented the multi-sig action indexer and pending approvals REST API (#1085), verified
all acceptance criteria, passed all unit and integration tests, and created branch
feat/multisig-action-indexer-1085.

Full Description

  1. Indexer Pipeline (src/modules/indexer/multisig-action-indexer.service.ts):

    • Processes ActionProposed, ActionSigned, and ActionExecuted governance events with robust normalization.
    • Upserts action details into multisig_actions and records signatures in signatures.
    • Handles deduplication and replay avoidance via Prisma unique constraints (P2002).
  2. REST API & Services (src/modules/multisig/):

    • GET /multisig/actions/pending: Lists pending multi-sig actions with accurate signature count, threshold, total
      signers, and signer breakdown.
    • GET /multisig/actions/:action_id: Retrieves single action detail with parameter data (payload/params) and
      complete signer list.
    • GET /multisig/actions/history: Lists completed and expired actions with execution/expiration outcomes and
      pagination support.
    • Signer eligibility validation checking against on-chain contract state via getLedgerEntries and
      ADMIN_MULTISIG_WALLETS environment configuration.
  3. Prisma Schema (prisma/schema/multisig.prisma):

    • Added MultisigAction and Signature models mapped to "multisig_actions" and "signatures" tables with proper
      relations and indexes.
  4. Testing:

    • Comprehensive unit and integration test suites covering event indexing, REST endpoints, error handling, and
      signer eligibility validation.

closes #1085

@drips-wave

drips-wave Bot commented Oct 20, 2026

Copy link
Copy Markdown

@VictorEzenma Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Chucks1093

Copy link
Copy Markdown
Member

⚠️ Merge Conflict Detected

This PR currently has a merge conflict and cannot be merged until it is resolved.

Please rebase or merge the latest changes from the base branch into your branch and push again.

1 similar comment
@Chucks1093

Copy link
Copy Markdown
Member

⚠️ Merge Conflict Detected

This PR currently has a merge conflict and cannot be merged until it is resolved.

Please rebase or merge the latest changes from the base branch into your branch and push again.

@Chucks1093

Copy link
Copy Markdown
Member

✅ PR Ready for Review

Due to a recent malware incident affecting our repositories, all PRs are required to pass automated security checks before being reviewed for merging.

This PR has passed all automated checks:

  • ✅ Security scan — no malicious code detected
  • ✅ No merge conflicts
  • ✅ CI checks passed

Next step: Please share this PR link in our Telegram group so a maintainer can review and merge it: https://t.me/c/accesslayerorg/8514

@Chucks1093
Chucks1093 merged commit 40da723 into accesslayerorg:main Oct 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build multi-sig action indexer and pending approvals REST API

3 participants