Repository navigation
[AMORO-4459][OpenAPI] Migrate SDK tests to JUnit 5 - #4460
Open
hutiefang76 wants to merge 1 commit into
Open
hutiefang76 wants to merge 1 commit into
hutiefang76 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The OpenAPI SDK is the agreed SDK-only slice of the JUnit migration in #4203. Its health-check test still uses JUnit 4 annotations and Java
assertstatements.Closes #4459. Closes part of #4203.
Brief change log
OpenAPITestto Jupiter lifecycle/test annotations and always-active Jupiter assertions, preserving all four response checks and WireMock's dynamic port and cleanup.How was this patch tested?
JDK 17, before and after the migration:
Both runs executed
OpenAPITest: 1 test, 0 failures, 0 errors, 0 skipped. The build also passed the SDK's Spotless and Checkstyle checks.All 33 modules in the default reactor passed. The SDK is enabled separately by
-Popenapi-sdkand is covered by the first command. Upstream CI passed at1b9d1c07: the OpenAPI SDK build ranOpenAPITest(1 test, 0 failures, 0 errors, 0 skipped); the JDK 11 dependency build succeeded with tests skipped, and the PR labeler passed.Documentation
No new feature; documentation is not applicable.
Implementation and this description were prepared with AI assistance.