Skip to content

[AMORO-4459][OpenAPI] Migrate SDK tests to JUnit 5 #4460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hutiefang76 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[AMORO-4459][OpenAPI] Migrate SDK tests to JUnit 5 #4460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions amoro-openapi-sdk/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,6 @@
</dependency>

<!-- test dependencies -->
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>com.github.tomakehurst</groupId>
<artifactId>wiremock-jre8</artifactId>
Expand Down
21 changes: 11 additions & 10 deletions amoro-openapi-sdk/src/test/java/org/apache/amoro/openapi/OpenAPITest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,22 @@
import static com.github.tomakehurst.wiremock.client.WireMock.get;
import static com.github.tomakehurst.wiremock.client.WireMock.stubFor;
import static com.github.tomakehurst.wiremock.client.WireMock.urlEqualTo;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;

import com.github.tomakehurst.wiremock.WireMockServer;
import org.apache.amoro.openapi.api.HealthApi;
import org.apache.amoro.openapi.invoker.ApiClient;
import org.apache.amoro.openapi.model.Response;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;

public class OpenAPITest {
private WireMockServer wireMockServer;
private String basePath;

@Before
@BeforeEach
public void setup() {
wireMockServer = new WireMockServer(0);
wireMockServer.start();
Expand All @@ -45,14 +47,13 @@ public void setup() {
basePath = "http://localhost:" + port;
}

@After
@AfterEach
public void teardown() {
wireMockServer.stop();
}

@Test
public void testSdkCall() throws Exception {
String json = "{\"message\":\"string\",\"code\":0,\"result\":{}}";
stubFor(
get(urlEqualTo("/api/ams/v1/health/status"))
.willReturn(
Expand All @@ -63,9 +64,9 @@ public void testSdkCall() throws Exception {
ApiClient apiClient = new ApiClient().setBasePath(basePath);
HealthApi api = new HealthApi(apiClient);
Response healthResponse = api.apiAmsV1HealthStatusGet();
assert healthResponse.getCode() == 0;
assert healthResponse.getMessage().equals("");
assert healthResponse.getResult() instanceof java.util.Map;
assert ((java.util.Map<?, ?>) healthResponse.getResult()).isEmpty();
assertEquals(0, healthResponse.getCode());
assertEquals("", healthResponse.getMessage());
assertTrue(healthResponse.getResult() instanceof java.util.Map);
assertTrue(((java.util.Map<?, ?>) healthResponse.getResult()).isEmpty());
}
}
Loading