Repository navigation
Name the store holding the span a GenAI evaluation was produced from - #177
Merged
Merged
Conversation
3 of 6 tasks
wu-sheng
added a commit
to apache/skywalking
that referenced
this pull request
Oct 19, 2026
wu-sheng
added a commit
that referenced
this pull request
Oct 19, 2026
…aceStorage (#178) Reverts #177. GenAITraceRefType itself now names the store holding the span an evaluation was produced from: SKYWALKING_NATIVE, OTLP for OTLP spans stored as received (receiver-otel `otlpTraceStorage: otlp`), and the new ZIPKIN for spans received by receiver-zipkin or converted from OTLP with `otlpTraceStorage: zipkin`. OTLP and Zipkin spans are both addressed by trace ID and span ID. The separate GenAITraceRef.storage field and GenAITraceStorage enum from #177 are removed; no release shipped them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GenAITraceRef.typeis the span's addressing scheme, and anOTLPreference can point into two different stores: OTLP spans stored as received (receiver-otelotlpTraceStorage: otlp, the default), and Zipkin spans, either received byreceiver-zipkinor converted from OTLP withotlpTraceStorage: zipkin.receiver-zipkinruns independently ofotlpTraceStorage, so one OAP can hold judged spans in both, and a client has no way to tell which one to read the trace from.This adds
GenAITraceRef.storage: GenAITraceStorage(SKYWALKING_NATIVE,OTLP,ZIPKIN).typeis unchanged: it stays the addressing scheme, andGenAITraceScopeConditionkeeps matching OTLP and Zipkin spans the same way.storageis null only on an OTLP-addressed record written before the store was recorded.Implementation: apache/skywalking#14152, which points its submodule at this branch.