Repository navigation
Fix parsing of connections where variables have the same name in different components - #1500
Merged
Merged
Conversation
hsorby
commented
Oct 12, 2026
hsorby
commented
Contributor
- Fixes Connections from CellML 1.0/1.1 models are reported as an error when not unique #1499.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused parser correction is consistent with component-relative mapping semantics and has appropriate regression coverage.
0 open findings
What changed in this PR
Fixes false duplicate-connection errors by preserving component-relative variable ordering.
Changes:
- Removes alphabetical normalization of mapped variable pairs.
- Adds CellML 1.1 and generated CellML 2.0 regression coverage.
- Updates the expected duplicate diagnostic ordering.
| File | Description |
|---|---|
src/parser.cpp |
Preserves variable_1/variable_2 ordering. |
tests/connection/connection.cpp |
Adds regression tests and updates expectations. |
tests/resources/cellml1X/connections.cellml |
Provides a two-way CellML 1.1 fixture. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Is this ready to be reviewed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.