Repository navigation
[chuchi] don't intercept handled clicks, other buttons and other targets - #11
Open
noah-meierlabs wants to merge 1 commit into
Open
noah-meierlabs wants to merge 1 commit into
noah-meierlabs wants to merge 1 commit into
Conversation
A click that another handler already prevented, a click with another button than the main one, and links into another window or frame (_top, _parent, a named target, not only _blank) were opened by the router. Found in zipp's studio, which had to stop such clicks itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A click another handler already prevented (
e.defaultPrevented), a click with another button than the main one, and links into another window or frame (_top,_parent, a named target, not only_blank) were opened by the router.Found while moving zipp's studio to chuchi's router; zipp had to stop such clicks itself.
🤖 Generated with Claude Code