Skip to content

[chuchi] don't intercept handled clicks, other buttons and other targets #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noah-meierlabs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[chuchi] don't intercept handled clicks, other buttons and other targets #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion chuchi/src/routing/Router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,10 +410,14 @@ function shouldInterceptClick(
e: MouseEvent,
link: HTMLAnchorElement | null,
): boolean {
// another handler took care of it, or not the main button
if (e.defaultPrevented || e.button !== 0) return false;
const openInNewTab = e.metaKey || e.ctrlKey || e.shiftKey;
const saveLink = e.altKey;
if (!link || !link.href || openInNewTab || saveLink) return false;
if (link.target.toLowerCase() === '_blank') return false;
// another window or frame: _blank, _top, _parent or a named one
const target = link.target.toLowerCase();
if (target && target !== '_self') return false;
if (link.hasAttribute('download')) return false;
if (!link.href.startsWith('http')) return false;

Expand Down
Loading