Repository navigation
[chuchi] end domReady of a replaced request too - #13
Open
noah-meierlabs wants to merge 1 commit into
Open
noah-meierlabs wants to merge 1 commit into
noah-meierlabs wants to merge 1 commit into
Conversation
When a newer request replaced one during its data step, openReq returned without releasing the DOM barrier, so a listener that awaited domReady of the replaced request waited forever. zipp's studio did that after a redirect and its page loader never finished. domReady now resolves with true there, like dataReady. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a newer request replaces one during its data step,
openReqreturns after the data barrier without ever readying the DOM barrier. A request listener that awaitsrouting.domReady()of the replaced request then waits forever.zipp's studio hit this: on a redirect its
onRoutehandler opened the new url and awaiteddataReady()anddomReady()of the old request, and the page loader (counted down in afinally) never finished. zipp works around it now, but the promise should not hang.Now
domReady()of a replaced request resolves withtrue, likedataReady().Tested by patching the built
Router.jsin zipp's studio and running its browser test of the redirect with the old handler: the loader finishes.🤖 Generated with Claude Code