Skip to content

[chuchi] end domReady of a replaced request too #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noah-meierlabs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[chuchi] end domReady of a replaced request too #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion chuchi/src/routing/Router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,8 +254,12 @@ export default class Router<C = any> {

this.newRequest.set(req);
// if version changed
if (await dataBarrier2.ready(hasVersionChange()))
if (await dataBarrier2.ready(hasVersionChange())) {
// a listener may still wait for domReady: it ends too, with true
// like dataReady, instead of never
domBarrier2.ready(true);
return console.log('request overriden, version changed');
}

// a pending scroll update belongs to the previous request, the scroll
// position gets stored below
Expand Down
Loading