Skip to content

fix(visual-builder): name the hovered entry in the reference map request - #672

Merged
kirtesh-cstk merged 1 commit into
develop_v4from
fix/field-label-reference-map-nonblocking
Oct 30, 2026
Merged

kirtesh-cstk merged 1 commit into
develop_v4from
fix/field-label-reference-map-nonblocking

Conversation

@kirtesh-cstk

@kirtesh-cstk kirtesh-cstk commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

What changed

The field label's REFERENCE_MAP request now names the hovered field's entry: { entry_uid, content_type_uid, locale } instead of {}. The editor can then answer for that entry alone instead of building the map for every entry on the page. For a field on the page entry it can answer at once, since the page entry is never looked up for the map.

  • getReferenceParentMap(fieldMetadata) sends the hovered field's entry identity; the call site passes props.fieldMetadata.
  • The response shape and how the label reads it are unchanged.
  • Editors that ignore the payload behave exactly as before.

Test evidence

  • npx tsc --noEmit: 0 errors
  • npx eslint on the changed files: 0 errors
  • Full suite: 118 files, 918 tests passed
  • New fieldLabelWrapper.referenceMapRequest.test.tsx: the request carries the hovered field's entry uid, content type and locale. It fails on develop_v4.

Measured on a production site with the matching editor change (the site's bundled SDK patched in the browser to send this payload): hovering fields of the page entry went from about 0.9s with 2 /references calls to about 0.1s with none. Fields of other entries are unchanged.

Needs manual QA

With the editor change deployed: hover fields of the page entry (no "referenced from" badge, label loads at once), then fields of a referenced entry (badge and tooltip still appear).


🤖 Generated with Claude Code

@kirtesh-cstk
kirtesh-cstk requested a review from a team as a code owner October 29, 2026 07:55
@snyk-io

snyk-io Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 2 0 10 ✅ Passed
🟠 High Severity 2 0 25 ✅ Passed
🟡 Medium Severity 1 0 500 ✅ Passed
🔵 Low Severity 1 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 68.72% 2597 / 3779
🔵 Statements 67.6% 2640 / 3905
🔵 Functions 66.28% 468 / 706
🔵 Branches 63.07% 1573 / 2494
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/components/fieldLabelWrapper.tsx 60.9% 62.62% 69.56% 61.68% 48-49, 64-65, 113-116, 150-160, 180-182, 260-269, 276-279, 314-317, 322-349, 402, 407-410, 416, 575
Generated in workflow #958 for commit f19df3e by the Vitest Coverage Report Action

The field label asked the editor for the whole reference map on every
hover, which the editor builds by looking up every entry on the page.
The request now carries the hovered field's entry uid, content type and
locale, so the editor can answer for that entry alone, at once for the
page entry. Editors that do not read the payload behave as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kirtesh-cstk
kirtesh-cstk force-pushed the fix/field-label-reference-map-nonblocking branch from 41098dd to f19df3e Compare October 29, 2026 15:58
@kirtesh-cstk kirtesh-cstk changed the title fix(visual-builder): show the field label without waiting for the reference map fix(visual-builder): name the hovered entry in the reference map request Oct 29, 2026
@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 2 0 10 ✅ Passed
🟠 High Severity 2 0 25 ✅ Passed
🟡 Medium Severity 1 0 500 ✅ Passed
🔵 Low Severity 1 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

@karancs06 karancs06 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@kirtesh-cstk
kirtesh-cstk merged commit 923344d into develop_v4 Oct 30, 2026
10 of 11 checks passed
@kirtesh-cstk
kirtesh-cstk deleted the fix/field-label-reference-map-nonblocking branch October 30, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants