Repository navigation
fix(visual-builder): name the hovered entry in the reference map request - #672
Merged
kirtesh-cstk merged 1 commit intoOct 30, 2026
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
The field label asked the editor for the whole reference map on every hover, which the editor builds by looking up every entry on the page. The request now carries the hovered field's entry uid, content type and locale, so the editor can answer for that entry alone, at once for the page entry. Editors that do not read the payload behave as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kirtesh-cstk
force-pushed
the
fix/field-label-reference-map-nonblocking
branch
from
October 29, 2026 15:58
41098dd to
f19df3e
Compare
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The field label's
REFERENCE_MAPrequest now names the hovered field's entry:{ entry_uid, content_type_uid, locale }instead of{}. The editor can then answer for that entry alone instead of building the map for every entry on the page. For a field on the page entry it can answer at once, since the page entry is never looked up for the map.getReferenceParentMap(fieldMetadata)sends the hovered field's entry identity; the call site passesprops.fieldMetadata.Test evidence
npx tsc --noEmit: 0 errorsnpx eslinton the changed files: 0 errorsfieldLabelWrapper.referenceMapRequest.test.tsx: the request carries the hovered field's entry uid, content type and locale. It fails ondevelop_v4.Measured on a production site with the matching editor change (the site's bundled SDK patched in the browser to send this payload): hovering fields of the page entry went from about 0.9s with 2
/referencescalls to about 0.1s with none. Fields of other entries are unchanged.Needs manual QA
With the editor change deployed: hover fields of the page entry (no "referenced from" badge, label loads at once), then fields of a referenced entry (badge and tooltip still appear).
🤖 Generated with Claude Code