Repository navigation
ci: unit tests on pull requests (Node 24); untrack coverage; declare and prune dependencies - #69
pritesh-jain-cstk wants to merge 4 commits into
Conversation
…utput MKT-22143. - .github/workflows/unit-test.yml: build and test:coverage on every PR and push to master, Node from the new .nvmrc (24, current LTS). - karma coverage check at 90% (statements, branches, functions, lines); only test:coverage enforces it, and CI runs that. - coverage/ was tracked and rewritten by test runs: untracked and ignored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…endencies MKT-22143. .eslintrc extends airbnb-base/legacy, which came in only through eslint-config-airbnb. Removed (imported, configured or scripted nowhere): @babel/cli, babel-eslint, braces, jasmine, jsdoc-to-markdown, karma-eslint, karma-spec-reporter, nyc, webpack-dev-server, eslint-config-airbnb. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
MKT-22143. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
Branch graph
Epic MKT-21682. This PR is highlighted. Only [Routine] depends on [Tests]; the rest are independent.
Merge order: #68 before #69 (#69 is based on #68). #64 and #69 both change
package.jsonandpackage-lock.json: merge #64 first, then bringmasterinto #69 with a merge (no rebase) and regenerate the lock withnpm install --legacy-peer-deps(expect a lock conflict). #65, #66, #67 and #70 are independent.What
Jira: MKT-22143
Depends on #68 (base branch; CI runs its tests).
Consumer impact: none. Only devDependencies, CI and ignored files change; the runtime dependencies (
post-robot,wolfy87-eventemitter) and thedistbuild inputs are the same..github/workflows/unit-test.yml: build andtest:coverageon every PR and push tomaster, Node from the new.nvmrc(24, current LTS). No workflow ran tests on PRs before; only the release workflow did (Node 16, actions v2; left alone here). Workflow files need@contentstack/security-adminreview; this is a draft and no review is requested.webpack.config.js: ESLintfix: !process.env.CI, so CI builds report lint problems instead of rewriting sources (no change todist: nothing is auto-fixable today). Lint warnings are not gated (26 pre-existingmax-len/no-consolewarnings).test:coverageenforces it and CI runs that. Current: 97.34 / 96.24 / 98.62 / 97.23.coverage/(43 files, rewritten by test runs) untracked and ignored; this isroutine.clean-install-build.package.json: declareseslint-config-airbnb-base(.eslintrcextendsairbnb-base/legacy; it came in only througheslint-config-airbnb) and removeseslint-config-airbnb,@babel/cli,babel-eslint,braces,jasmine,jsdoc-to-markdown,karma-eslint,karma-spec-reporter,nyc,webpack-dev-server(imported, configured or scripted nowhere; checked with depcheck and grep). The lock loses 313 entries; onlycall-bind(1.0.8 -> 1.0.9) and one nestedsemverpatch move. npm audit: 46 (4 Critical, 25 High) -> 31 (0 Critical, 21 High).--legacy-peer-deps:eslint-config-airbnb-base@15peers eslint 8 and the repo is on eslint 9. Fixing that is an ESLint flat-config migration, not done here.package.jsonandpackage-lock.json; whichever merges second needsnpm install --legacy-peer-depsto resolve the lock.Readiness items
routine.clean-install-build,routine.dependencies, CI hygieneCommands (exit codes, Node 24 locally)
npm cinpm ci --legacy-peer-depsnpm run buildlint / typechecknpm testnpm audit --omit=devnpm auditnpm run test:coverageCommits went through the repo's hooks (GitGuardian pre-commit and pre-push); none bypassed. Local Snyk cannot authenticate (org permission / 401), so the PR's Snyk checks are the scan.
CI:
security-licensefails here as onmaster: it requires the current year inLICENSE(still 2019-2025). Fixed by #64 (DX-29607), not by this PR. All Snyk, GitGuardian, CodeQL and policy checks pass. The newUnit testsworkflow ran green on this PR (build, 133 specs, coverage gate).🤖 Generated with Claude Code