Repository navigation
refactor(planar-SAT): share orthogonal route decidability - #1196
Merged
Merged
Conversation
This was referenced Oct 26, 2026
Collaborator
|
Review claimed by reviewer-claude-c4b0c164-87 (agent review) at 27d5220. |
Collaborator
|
reviewer-claude-c4b0c164-87 — APPROVED at 27d5220 Agent review, not human approval. I reviewed the single commit on top of #1195's head
|
SamuelSchlesinger
force-pushed
the
feat/parsimony-counting-polish
branch
from
October 26, 2026 21:48
de1aecb to
306b34a
Compare
SamuelSchlesinger
changed the base branch from
feat/parsimony-counting-polish
to
main
October 26, 2026 22:06
SamuelSchlesinger
force-pushed
the
feat/parsimony-geometry-polish
branch
from
October 26, 2026 22:06
27d5220 to
8e9b6ed
Compare
Collaborator
|
Coordinator restack ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the nonblocking nits from #1174’s review, after #1195. This follow-up does not modify the lower branches. Closes #1191.
A public decidability instance for
IsOrthogonalreplaces six identical private instances beside the existing foundational predicate and axis-alignment instance. The decision procedure is unchanged: check each consecutive segment. Existing certified routes exercise the shared instance. The unused SAT-specific boundary wrapper is removed; the shared paired-port theorem remains. The distinct one-way wire API is retained.Documentation now lists the paired crossover’s unique-extension and evaluation theorems and credits Hunt et al. for crossover parsimony. Their Theorem 3.2, pinned arXiv v1, p. 5 states: “The problem 3Sat has a parsimonious planar crossover box.” Definition 3.1 supplies the unique-extension condition. Here that condition is the unique full assignment for each pair of Boolean inputs; the adapted 13-variable table is checked in Lean. Clause tables, coordinates, routes and mathematical certificate statements are unchanged.
Validation at 27d5220: all six required local gates pass, using four Lean threads, including the existing finite and continuous geometry certificates. Hygiene, changed-file, documentation configuration and catalogue checks pass.
Self-review checked the shared instance against all six removed copies, the unused wrapper’s references, and the source credit against the pinned paper. Outside-fleet coordinator review is requested. Selected formal abstracts, catalogue scope and rendering are unaffected.
AI assistance: implemented and self-reviewed with Codex (gpt-6.1-sol).