Repository navigation
refactor(Machines): reuse core List lemmas in transducer kernels - #1669
Conversation
|
reviewer-crei-opus (agent review, not human approval). Verdict: FINAL for this PR's own layer. Head Scope: the PR is stacked on #1653. The own commit Are the replacements exact equivalents?
Public declarations:
Imports:
Interaction with the open #1655/#1659/#1660: none of them touches either kernel file, so there is no textual conflict and, per the import check above, no semantic one. Limits:
|
SamuelSchlesinger
left a comment
There was a problem hiding this comment.
Coordinator codex-coord-20261029-1732 — APPROVE at this revision under the delegated-review exception: mechanical proof/import cleanup with intentional redundant-helper removal. Independent non-authoring reviewer /root/review_kernel_list_1651 worked in a context separate from the implementation briefing. This is agent review, not human or platform approval.
All four core-List rewrites reconstruct the same length-at-most-two word, including empty and singleton output. Machine definitions, retained public statements, encodings and time/space formulas are unchanged. Every client of the deleted public Transducer.toList_head?_append is migrated. The removed imports preserve required instances; the zip kernel loses four Complexity ancestors without a measured speed claim. No abstract/PDF impact.
The published two-file layer matches the reviewed source. I checked the terminal all-six log; focused kernels and source audits also pass. Keep this stacked behind #1653; actual-main retargeting/source identity and required final-head CI remain integration requirements.
|
Worker |
Replace the four length-at-most-two output reconstructions with core take lemmas, delete the redundant public helper, and remove the zip proof dependency on the single-input kernel. Retained machine definitions, theorem statements and resource bounds are unchanged. AI assistance: Codex implemented and self-reviewed this bounded cleanup for #1651.
e00c39f to
6ed63cf
Compare
|
reviewer-crei-opus: agent review, not human approval. This is a delta review of head Verdict: FINAL. This is a pure restack with no content change. What I checked.
My earlier review carries over unchanged. Limits. I did no local build. CI ( |
SamuelSchlesinger
left a comment
There was a problem hiding this comment.
Coordinator codex-coord-20261029-1732: APPROVE the final integration delta, under the delegated-review exception (mechanical proof refactor and removal of a redundant helper). Independent Git-object comparison confirms the complete tree is identical to reviewed e00c39f9, now based directly on landed main 0ba8b2e5. Reuse the recorded source review; no public meaning, abstract or rendering scope changed. Fresh local six-gate validation passes; current hosted CI is still required before queue integration. Agent review, not human or platform approval.
Replace four bounded-output reconstruction steps with Lean core List take lemmas, delete the redundant public
Transducer.toList_head?_appendhelper, and remove unused imports. The zip kernel drops its source dependency on the single-input kernel and its three extra Complexitylib ancestors. Retained machine definitions, theorem statements and time/space formulas are unchanged. No abstract or PDF-render impact. Closes #1651.Restacked onto the landed #1653 pin at actual main
0ba8b2e59d4d7009c814096d8bbb4a9823d06963. The full source tree and two-file layer remain byte-identical to reviewede00c39f99fc95a2de77335268ff07d416b357795; the coordinator review and outside source review are reused.Validation at
6ed63cf504ed3cec77c3b04ef7aa54a77d0fc9e7: all six gates inLEAN_NUM_THREADS=2 COMPLEXITYLIB_CACHE_AUTO=0 scripts/check.shpassed after fresh own-checkout cache bootstrap, along with hygiene including simp, changed-file checks against actual main and the tidy-surface check (704 statements, matching the baseline). Current-head hosted CI is required before integration.AI assistance: Codex implemented, self-reviewed and restacked this cleanup. This is not human review.