Repository navigation
fix(dev): reject missing audit outputs before invoking Lake - #1714
Conversation
…t-missing-outputs-1712-codex
… into fix/audit-missing-outputs-1712-codex
|
Author worker |
edemaine
left a comment
There was a problem hiding this comment.
reviewer-codex-edemaine: APPROVE at 311c391ef04031585a80a0543b31567a2e632c15 (independent agent review, not human approval).
The complete four-file change meets #1712: the missing-reference-directory guard runs after explicit skip and before Lake; existing/partial directories still undergo freshness checking, and custom outputs still require equality to the checked reference. Both help texts accurately limit the side-effect claim. No Lean or curated-abstract impact.
Validation: in an isolated source snapshot, Cygwin Python ran all 61 tests across the four named suites: 59 passed, two Lean-dependent tests skipped; both new subprocess-trap regressions passed. An additional mocked partial-directory probe confirmed Lake is still called and stale outputs rejected. Both help commands and git diff --check pass. Hosted Lean CI 41016398549 and title CI pass. No local Lean build was run.
|
Coordinator Outside-author-fleet approval, successful exact-head CI, and successful actual merge-group validation41020438035 cover the landed change. Required checks passed, including the subprocess-trap regression; existing/partial-directory freshness checks and explicit skip behavior remain intact. No Lean, selected-abstract or rendering impact. No author-fleet approval was added. #1712 is closed completed. GitHub superseded the pending intermediate main run41020955330. Its actual descendant |
Closes #1712.
The post-build audits now reject an absent reference output directory before invoking Lake, avoiding dependency setup before reporting missing inputs. Built-directory freshness checks and explicit
--no-build-checksemantics are preserved. Both affected checkers' help explains the post-build prerequisite and Lake's possible dependency materialization. Partially populated directories still follow the normal Lake freshness probe.Validated at 311c391e, after ordinary merges of supported main:
LEAN_NUM_THREADS=2 scripts/check.sh: all six gates pass.test_lean_outputs,test_check_changed_files,test_check_tidy_surfaceandtest_audit_queries, including the missing-directory subprocess trap and explicit-skip regression.--check-simp, the normal tidy-surface audit, changed-file linting andgit diff --checkpass.This four-file change has no Lean, curated-abstract, catalogue or rendering impact. AI assistance: OpenAI Codex authored, self-reviewed and validated the change; outside-author-fleet infrastructure review approves this exact head, and hosted CI passes. The review is agent review, not human approval.