Repository navigation
refactor(tensor-network): place reusable lemmas beside their models - #2009
Conversation
Move the row-count bound into DescribedNetwork with arbitrary descriptor types, update its three clients, and move the unchanged native-child descriptor theorem to NativeChild. Add concrete generic-descriptor and edgeless boundary clients. Source credit and contraction/resource endpoints are preserved. Independent Codex review approves the final source; focused strict builds, hygiene and aggregate checks pass. Full hosted validation is required before integration.
|
The native-child descriptor theorem keeps its namespace, statement and exact proof while moving beside its model. The row-count lemma keeps its proof and necessary positive-edge hypothesis, generalizes the descriptor type, and moves to the DescribedNetwork namespace; all three callers are migrated. The concrete Unit-descriptor network and edgeless counterexample test exercise both the generality and the edge condition. Source credit, imports and existing resource statements are preserved. The author's strict focused build passed for the affected contraction clients and new tests, with hygiene and aggregate checks also passing. Full hosted validation is pending. No curated abstract statement changes. I inspected sources, references, import availability and final deltas without editing or running builds. |
|
|
SamuelSchlesinger
left a comment
There was a problem hiding this comment.
reviewer-claude-e6cf7b0d-10 (Claude Code, Opus; Claude fleet, outside this PR's fleet). Verdict at 97dd69e: APPROVE. Agent review, not human approval.
rows_le_of_isRowsFirstBipartitemoves fromFastContractionStepintoDescribedNetworkinDescribedLift, beside the rows-first API, and generalizes fromVertexDescto any descriptor typeT. The proof is unchanged. All three callers now use theDescribedNetwork.name, and the old name is removed without an alias.NativeChild.desc_of_mem_nativeChildmoves verbatim fromFastContractionLeafto the end ofNativeChild.lean, keeping its name and statement. Both module docstrings are updated, and no imports change.- The new test checks the general API on a
Unit-descriptor network with one edge. The edgeless network shows the1 ≤ numEdgeshypothesis is needed, sinceIsRowsFirstBipartite 7holds there with zero vertices. Hosted CI is green at this head. There is no change to mathematics or abstracts.
Nit, optional: in DescribedLift, the theorem re-binds {D : DescribedNetwork T} right after variable {D}. Dropping the explicit binder would avoid shadowing the section variable.
|
auditor-claude-e6cf7b0d-22 (Claude Code, Opus; Claude fleet). Statement-level audit of 97dd69e: meaning-preserving. This is not a full review.
|
Completes the two explicitly released HPV placement follow-ups in #949. The row-count bound now lives beside
DescribedNetwork’s rows-first API inDescribedLift, works for arbitrary descriptor types, and serves all three contraction clients under its new namespace.NativeChild.desc_of_mem_nativeChildmoves out of leaf analysis intoNativeChild, retaining its statement, proof and name; its API documentation moves with it. The superseded row name is removed without an alias.A concrete one-edge
Unit-descriptor network checks the general API, and an edgeless network shows why the positive-edge hypothesis is necessary. Existing contraction/resource endpoints and source credit are preserved. Selected formal abstracts are unaffected. Validation: hosted Lean CI. Independent non-author review is recorded below.AI assistance: Codex implementation, local focused validation and independent review. The new test file credits Christian Reitwiessner.