feat(ime): emoji toggle in the editing toolbar (#61, option 2) - #65
Merged
Merged
Conversation
A 😀 button in the editing toolbar switches the engine to the Emoji alphabet; tapping Abc switches back to the remembered alphabet and re-anchors from the target field so predictions continue mid-sentence. - Button hidden until the engine's data bundle ships the Emoji alphabet (DasherCore#96 lands the data; next submodule bump lights this up) - Return alphabet persisted in dasher_ime prefs — engine restarts in Emoji mode (its own setting) still know the way back - EditingToolbar gains an optional onToggleEmoji constructor param; null (other call sites) hides the button entirely Refs Dasher-Android#61, DasherCore#96. Signed-off-by: will wade <willwade@gmail.com>
willwade
force-pushed
the
feat/emoji-toggle
branch
from
September 18, 2026 16:16
5401201 to
adcc1fb
Compare
willwade
added a commit
that referenced
this pull request
Sep 19, 2026
Bumps the DasherCore submodule to the Emoji-alphabet merge (DasherCore#96). The app bundles the submodule's Data dir directly, so this is what lights up the 😀/Abc toggle from #65 — no Kotlin changes needed. **To test after merge:** install the debug build, open any text field with the Dasher IME → the editing strip (←/→/⌫/Sel/Cp/Ps) now shows **😀 at the right end**. Tap it → the tree switches to 9 emoji groups (smileys, gestures, hearts, people, animals, food, travel, objects, communication + separators). Tap **Abc** → back to your previous alphabet, predictions re-anchored mid-sentence. Note: a fresh install (or clearing app data) forces DataInstaller to re-extract the new assets — an upgrade install over v0.1.20 may keep the old extracted data dir. If the button doesn't appear on upgrade, clear Dasher's storage once. Signed-off-by: will wade <willwade@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
😀 button in the RFC 0019 editing toolbar: switches the engine to the Emoji alphabet (DasherCore#96 — pure data asset, 9 topical groups, multi-codepoint nodes). Tap
Abcto return to the remembered alphabet.Behaviour
dasher_imeprefs (engine restarts in Emoji mode still know the way back)reanchorEngineToTarget()re-seeds from the target field so predictions continue mid-sentenceEditingToolbar.onToggleEmojiis optional; default null hides the button (no other call-site changes)Testing
compileDebugKotlin+ unit tests + lint cleanCloses #61 (option 2). Option 3 (English+emoji trained variant) tracked as follow-up in the issue.