chore: bump DasherCore to b00a4c8a — Emoji alphabet - #66
Merged
Merged
Conversation
Brings alphabet.emoji.xml + training_emoji.txt into the bundled data (assets.srcDir third_party/DasherCore/Data), which lights up the emoji toggle added in #65: the 😀 button appears in the editing toolbar once the engine reports the Emoji alphabet. DasherCore#96. Signed-off-by: will wade <willwade@gmail.com>
2 tasks
willwade
added a commit
that referenced
this pull request
Sep 19, 2026
## What Moves the emoji toggle out of the IME editing strip and adds it to app mode: - **IME**: 😀 now sits in the Float/Hide top bar (Float | 😀 | Hide) — the editing strip goes back to being a pure edit-action row (←/→/⌫/Sel/Cp/Ps) - **App mode**: 😀 toggle in the bottom StatusBar, immediately left of the alphabet picker — the placement Heide's feedback pointed at. Shown only when the engine ships the Emoji alphabet (DasherCore b00a4c8a, bumped in #66) ## Behaviour (shared) Toggle → Emoji alphabet, remember the previous one; toggle again → restore. The return alphabet lives in the shared `dasher_ime` prefs, so toggling in the app and restoring in the IME (or vice versa) works. App-mode toggles pin the alphabet choice like any explicit picker selection. ## Testing - [x] compileDebugKotlin, unit tests, lint — clean - [ ] Manual: IME top bar shows Float/😀/Hide; 😀 switches tree, Abc restores + re-anchors; app bottom bar shows 😀 left of picker Refs #61. Signed-off-by: will wade <willwade@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the DasherCore submodule to the Emoji-alphabet merge (DasherCore#96). The app bundles the submodule's Data dir directly, so this is what lights up the 😀/Abc toggle from #65 — no Kotlin changes needed.
To test after merge: install the debug build, open any text field with the Dasher IME → the editing strip (←/→/⌫/Sel/Cp/Ps) now shows 😀 at the right end. Tap it → the tree switches to 9 emoji groups (smileys, gestures, hearts, people, animals, food, travel, objects, communication + separators). Tap Abc → back to your previous alphabet, predictions re-anchored mid-sentence.
Note: a fresh install (or clearing app data) forces DataInstaller to re-extract the new assets — an upgrade install over v0.1.20 may keep the old extracted data dir. If the button doesn't appear on upgrade, clear Dasher's storage once.