Repository navigation
test: create users by handle in the scheduled commit and preview tests - #1186
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. Finishing Touches
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
productiontests fail again: #1136 (commit a scheduled commit now) and #1014 (local time in profile previews) were merged with tests that create users withusername, the column #1157 dropped when handles moved to profiles. Both now create them withhandle. Test-only.Validation
tests/Feature/ScheduledCommitsTest.phpandtests/Feature/Controllers/UserPreviewControllerTest.php: 66/66 locally (isolated Postgres)pest --parallel --ci --coverage --exactly=100.0: 4515/4515, 100% coverage