Repository navigation
Conversation
mloubout
reviewed
Oct 16, 2026
| __new__ = UnevaluableMixin.__new__ | ||
| def __new__(cls, *args, evaluate=None, **kwargs): | ||
| # A Mul will always be zero if any of its arguments are zero | ||
| if any(arg == 0 for arg in args): |
Contributor
There was a problem hiding this comment.
sympify(arg).is_zero is likely safer ==0 sometimes doesn't work
mloubout
reviewed
Oct 16, 2026
| if any(arg == 0 for arg in args): | ||
| return sympy.S.Zero | ||
|
|
||
| return cls.__base__.__new__(cls, *args, evaluate=False, **kwargs) |
Contributor
Author
There was a problem hiding this comment.
Quick copy-paste job and didn't spot it...
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3060 +/- ##
==========================================
- Coverage 84.23% 84.22% -0.01%
==========================================
Files 258 258
Lines 57070 57074 +4
Branches 4874 4875 +1
==========================================
Hits 48072 48072
- Misses 8170 8173 +3
- Partials 828 829 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.