Skip to content

dsl: Make unevaluated.Mul return Zero if any args are zero #3060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EdCaunt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

dsl: Make unevaluated.Mul return Zero if any args are zero #3060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion devito/symbolics/unevaluation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import sympy
from sympy import sympify

__all__ = ['Add', 'Mod', 'Mul', 'Pow']

Expand All @@ -18,7 +19,12 @@ class Mod(sympy.Mod, UnevaluableMixin):


class Mul(sympy.Mul, UnevaluableMixin):
__new__ = UnevaluableMixin.__new__
def __new__(cls, *args, evaluate=None, **kwargs):
# A Mul will always be zero if any of its arguments are zero
if any(sympify(arg).is_zero for arg in args):
return sympy.S.Zero

return super().__new__(cls, *args, evaluate=False, **kwargs)


class Pow(sympy.Pow, UnevaluableMixin):
Expand Down
Loading