Repository navigation
Conversation
GuardFactorNe inherited CondEq through GuardFactor ahead of CondNe, so it was an equality and printed `==`. Negating a subsampling guard thus reproduced the guard itself, selecting the timesteps on the subsampled grid instead of those off it
A condition SymPy folds to `false`, e.g. `time < 0`, was printed as `if (false)`, which is not C99 without `stdbool.h` and failed to compile
A condition such as `time >= 0` folds to `true` (`time` is nonnegative)
and gave a Cluster the guard {time: true}, distinct from no guard.
Buffering then created one buffer per guard for equivalent accesses
This was referenced Oct 16, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3061 +/- ##
==========================================
+ Coverage 84.23% 84.24% +0.01%
==========================================
Files 258 258
Lines 57070 57112 +42
Branches 4874 4875 +1
==========================================
+ Hits 48072 48115 +43
Misses 8170 8170
+ Partials 828 827 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three guard bugs that buffering exposes, each with a single-writer test against
opt='noop':GuardFactorNewas an equality. It inheritedCondEqahead ofCondNethroughGuardFactor, so negating a subsampling guard reproduced the guard: one equation underNot(GuardFactor(ct))with factor 2 printed(time)%(ctf) == 0and wrotef = [1, 0, 3, 0]instead of[0, 2, 0, 4].if (false)was emitted. A condition SymPy folds tofalse(e.g.time < 0) printedif (false), which is not C99 withoutstdbool.h: a compile error.{time: true}guards.time >= 0folds totrueand gave a Cluster a guard distinct from no guard, so buffering created one buffer per "guard" for equivalent accesses.Tests:
test_dimension.py::TestConditionalDimension::test_negated_factor_condition,::test_false_condition,test_buffering.py::test_true_condition_single_buffer. Each fails with only its commit's source change reverted.First of three stacked PRs: this one, then #3062 (copy-back skip rule) and #3063 (stale reads and lost writes).
🤖 Generated with Claude Code