Repository navigation
Conversation
The guard of the later copy-back is evaluated at the earlier one, so the skip is unsound if anything the guard reads, indices included, is written in between
This was referenced Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3061; the base switches to
mainonce that merges.The copy-back skip from #3050 evaluates the later write's guard at the earlier copy-back. If anything that guard reads (indices included) is written in between, the only firing write can be skipped. Single-writer reproducer (every Function has at most one firing write per step, slot and point):
At
time = 3the increment makescmfalse, so onlyEq(f, T)fires.f[:, 1, 1]is[0, 1, 2, 3]withopt='noop'and[0, 1, 2, 0]with buffering on main. The indirect-guard variant (the guard readsTthrough an index Function) gives[2, 3, 4, 5]vs[2, 3, 4, 0].The skip now applies only if nothing the later guard reads is written between the two copy-backs. Test:
test_buffering.py::test_buffering_same_slot_skip[mutable|indirect]; both fail with onlybuffering.pyreverted.Per the #3050 discussion, the cases with two firing writes to a slot in one step are not used as evidence here.
🤖 Generated with Claude Code